Fix statically linked concurrency on Linux #42071
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
added
the
concurrency
|
@swift-ci please test |
ktoso
approved these changes
Mar 28, 2022
Generating a statically-linked executable either with `-static-executable` or `-static-stdlib` that contains concurrency needs to link the concurrency libraries or the missing symbols will cause link failures. This patch adds dispatch and blocks runtime to the list of statically linked libraries. In the case of the static stdlib, it only adds them if the concurrency mechanisms use dispatch, otherwise it doesn't. For the static executable, it always adds them since that doesn't appear to be very configurable.
etcwilde
force-pushed
the
ewilde/link-dispatch-blocks-for-concurrency
branch
from
f51b59c to
1977a68
Compare
|
@swift-ci please test |
|
Broken by #42051 |
|
@swift-ci please test macOS |
|
@swift-ci please test Windows |
|
#42075 has now merged, which should hopefully fix things again. |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a statically-linked executable either with
-static-executableor-static-stdlibthat contains concurrency needsto link the concurrency libraries or the missing symbols will cause link
failures.
This patch adds dispatch and blocks runtime to the list of statically
linked libraries. In the case of the static stdlib, it only adds them if
the concurrency mechanisms use dispatch, otherwise it doesn't.
For the static executable, it always adds them since that doesn't appear
to be very configurable.