[NFC] Remove Python 2 imports from __future__ #42086
Conversation
dduan
force-pushed
the
dd/the-future-is-now
branch
from
ccaeffd to
c834ff5
Compare
|
swiftlang/swift-syntax#378 |
dduan
force-pushed
the
dd/the-future-is-now
branch
2 times, most recently
from
c81c64b to
c0a160e
Compare
|
swiftlang/swift-syntax#378 |
|
SwiftSyntax-related changes are looking good. @gottesmm @shahmishal Do you know if there is anything in our infrastructure that might still be requiring the Python 2 scripts or any other implications of dropping Python 2 support from the build scripts? |
|
ping 👋 I personally think this change poses minimal risk. If something went wrong, it should be fairly easy to revert because it's part of the project that rarely changes. |
|
I know that some folks (me) still run some older systems that still point |
|
@etcwilde I already had to do it for a few scripts that CI runs. I was planning to do the shebang changes you suggested in a separate PR. But I suppose it's a reasonable request. |
|
swiftlang/swift-syntax#378 |
|
Cool, thanks. I'd just meant for the ones changed in the initial PR, but this all looks good to me. It's a lot of files, but a really small change. Assuming things pass and no one else has issues with it, LGTM. |
The `__future__` we relied on is now, where the 3 specific things are all included [since Python 3.0](https://docs.python.org/3/library/__future__.html): * absolute_import * print_function * unicode_literals * division These import statements are no-ops and are no longer necessary.
dduan
force-pushed
the
dd/the-future-is-now
branch
from
b9477f6 to
946e05e
Compare
|
swiftlang/swift-syntax#378 |
|
swiftlang/swift-syntax#378 |
1 similar comment
|
swiftlang/swift-syntax#378 |
|
thank you for the reviews! |
The `__future__` we relied on is now, where the 3 specific things are all included [since Python 3.0](https://docs.python.org/3/library/__future__.html): * absolute_import * print_function * unicode_literals * division These import statements are no-ops and are no longer necessary. (cherry picked from commit 3dfc408)
The `__future__` we relied on is now, where the 3 specific things are all included [since Python 3.0](https://docs.python.org/3/library/__future__.html): * absolute_import * print_function * unicode_literals * division These import statements are no-ops and are no longer necessary. (cherry picked from commit 3dfc408) (cherry picked from commit 66bf05b)
The
__future__we relied on is now, where the 4 specific things areall included since Python 3.0:
These import statements will be no-ops and are no longer necessary.