[stdlib] Mark NFD and NFC as SPI #42124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-experimental-string-processing#240 |
rxwei
approved these changes
Mar 31, 2022
milseman
reviewed
Apr 3, 2022
underscore Unicode SPI
|
swiftlang/swift-experimental-string-processing#240 |
Swap the bases to unicodeScalarView
|
@swift-ci please smoke test |
|
@swift-ci please benchmark |
lorentey
reviewed
Apr 5, 2022
| @_spi(_Unicode) | ||
| @available(SwiftStdlib 5.7, *) | ||
| public struct Iterator { | ||
| var base: Unicode._InternalNFD<Substring>.Iterator |
| @_spi(_Unicode) | ||
| @available(SwiftStdlib 5.7, *) | ||
| public struct _NFC { | ||
| let base: Substring.UnicodeScalarView |
| @_spi(_Unicode) | ||
| @available(SwiftStdlib 5.7, *) | ||
| public struct _NFD { | ||
| let base: Substring.UnicodeScalarView |
There was a problem hiding this comment.
To avoid surprises, I recommend spelling out the memberwise initializer here. The compiler-provided one probably works fine, but it usually is a good idea to be explicit about things that might get exposed.
(E.g. I don't know for sure if the implicit initializer will be declared public or internal. internal would make more sense, but ¯\_(ツ)_/¯)
| @_spi(_Unicode) | ||
| @available(SwiftStdlib 5.7, *) | ||
| public struct Iterator { | ||
| var base: Unicode._InternalNFC<Substring>.Iterator |
Azoy
added a commit
to Azoy/swift
that referenced
this pull request
May 26, 2022
[stdlib] Mark NFD and NFC as SPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the normalization utilities NFD and NFC as
@_spi(Unicode)for use in_StringProcessing.