Don't diagnose non-Sendable captures in actor-isolated @Sendable closures #42126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures Another important step towards implementing SE-0338 semantics. Fixes rdar://90950355.
|
@swift-ci please smoke test |
ktoso
reviewed
Apr 4, 2022
| Task { | ||
| _ = sc // expected-warning{{capture of 'sc' with non-sendable type 'SomeClass' in a `@Sendable` closure}} | ||
| } | ||
| } |
There was a problem hiding this comment.
This is weird actually... are you saying this 3rd Task does NOT execute on the actor because does not capture self? That's insanely brittle isn't it? Isn't the model we explain that if "syntactically created inside an actor" then runs on actor...? 😕 We're not doing a good job explaining the actual semantics of the implicit executor inheritance tbh :~
There was a problem hiding this comment.
If you don't capture self, we shouldn't capture it on your behalf. At most, this could be a warning.
ktoso
reviewed
Apr 4, 2022
| func testNonSendableCaptures(sc: SomeClass) { | ||
| Task { | ||
| _ = self | ||
| _ = sc |
ktoso
reviewed
Apr 4, 2022
|
|
||
| Task { [sc,self] in | ||
| _ = self | ||
| _ = sc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another important step towards implementing SE-0338 semantics.
Fixes rdar://90950355.