-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add reference page for Sendable protocol. #42128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ec74b18
Add reference page for Sendable protocol.
amartini51 34306bc
Introduce an example explicitly.
amartini51 6c443e5
Match code listing markup used elsewhere.
amartini51 0089134
Apply suggestions from tech review
amartini51 32e0825
Revise per tech review feedback.
amartini51 c4b6f4b
Format bulleted lists the same throughout.
amartini51 c9bdda9
Add discussion of metatypes.
amartini51 2774f3d
Call out unsafe-sendable structs & enums.
amartini51 59e951a
Fix minor wording issues per review feedback
amartini51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth mentioning the other odd case, that metatypes (e.g.,
Int.Type
) are implicitlySendable
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I'm trying to tease out what facts about "sendable" the language concept belong in TSPL, versus the facts about
Sendable
the protocol that belong here. I was planning to talk about metatypes in TSPL, since you can't write something likeInt.Type: Sendable
. However, it sounds like that discussion belongs here, because the conformance is implicit like several other things that implicitly conform toSendable
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in c9bdda9.