Skip to content

SIL linker: don't try to synthesize witness tables for marker protocols. #42132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DougGregor
Copy link
Member

We never have them, we never need them, and we'll crash if there were
one for a conformance of a non-nominal type to such a protocol.

Fixes rdar://91126885 .

We never have them, we never need them, and we'll crash if there were
one for a conformance of a non-nominal type to such a protocol.

Fixes rdar://91126885 .
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@DougGregor DougGregor merged commit afed427 into swiftlang:main Apr 1, 2022
@DougGregor DougGregor deleted the sil-linker-no-fake-marker-protocol-conformances branch April 1, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants