RequirementMachine: Minor diagnostics fixes #42133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… protocol can be re-stated redundantly
…slightly to match GSB
…dConflict() and add debug output
|
@swift-ci Please smoke test |
We were building the signature twice, and adding the 'where' clause twice each time. The GSB magically uniqued them, whereas the Requirement Machine is not so forgiving.
…a GenericParamList Otherwise, we'll end up visiting it twice in InferredGenericSignatureRequest. The GSB uniques requirements seen this way, whereas the Requirement Machine does not, leading to redundant requirement diagnostics.
slavapestov
force-pushed
the
rqm-minor-diagnostics-fixes
branch
from
31ca258 to
2b766c2
Compare
|
@swift-ci Please smoke test |
| @@ -41,8 +41,7 @@ protocol P5b: P5a where A == Self {} | |||
| struct S5<X>: P5b {} // OK, A := S5<X> | |||
|
|
|||
|
|
|||
| protocol P6 where A == Never { // expected-error {{same-type constraint type 'Never' does not conform to required protocol 'P6'}} | |||
| // expected-error@+2 {{same-type constraint type 'Never' does not conform to required protocol 'P6'}} | |||
| protocol P6 where A == Never { // expected-error {{no type for 'Self.A' can satisfy both 'Self.A == Never' and 'Self.A : P6'}} | |||
There was a problem hiding this comment.
The new phrasing here sounds like a loss of clarity. Are the old phrasings on their way out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.