Skip to content

Revert "Merge pull request #42140 from artemcm/EnableRegexLiteralFlag" #42150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Apr 2, 2022

This reverts commit aaee1c4, reversing
changes made to 16d204b.

This is causing build failures on Windows.
https://ci-external.swift.org/job/swift-PR-windows/270/

…teralFlag"

This reverts commit aaee1c4, reversing
changes made to 16d204b.
@etcwilde etcwilde requested review from beccadax and artemcm April 2, 2022 00:57
@etcwilde
Copy link
Member Author

etcwilde commented Apr 2, 2022

@swift-ci please test Windows

@etcwilde
Copy link
Member Author

etcwilde commented Apr 2, 2022

@swift-ci please test

@etcwilde
Copy link
Member Author

etcwilde commented Apr 2, 2022

We may only need to revert the driver change here: swiftlang/swift-driver#1045, I'm not sure though?

@beccadax
Copy link
Contributor

beccadax commented Apr 2, 2022

I think we can get away with just reverting swift-driver, but we can hold on to this PR for a little while.

@etcwilde
Copy link
Member Author

etcwilde commented Apr 2, 2022

@etcwilde
Copy link
Member Author

etcwilde commented Apr 4, 2022

Alright, compnerd fixed the test here: #42153. We can close this one.

@etcwilde etcwilde closed this Apr 4, 2022
@etcwilde etcwilde deleted the ewilde/revert-regex-literals branch April 4, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants