[SourceKit] Disable cancellation of in-flight non-completion requests #42166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
We need to run SILGen for diagnostics (to actually get all diagnostics). All non-completion requests share an AST and thus they too run SILGen. Any lazy typechecking run in SILGen assumes that it succeeds. Cancellation can cause typechecking to fail here though, since we simply check the flag and error if it's set. This unfortunately has the ability to cause any any number of crashes since various invariants in SILGen are then broken. Disable cancellation of in-flight non-completion requests for now until we have a proper fix in place. Resolves rdar://91251017.
bnbarham
force-pushed
the
disable-cancellation
branch
from
f5ffda8 to
7cd4937
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to run SILGen for diagnostics (to actually get all diagnostics).
All non-completion requests share an AST and thus they too run SILGen.
Any lazy typechecking run in SILGen assumes that it succeeds.
Cancellation can cause typechecking to fail here though, since we simply
check the flag and error if it's set. This unfortunately has the ability
to cause any any number of crashes since various invariants in SILGen
are then broken.
Disable cancellation of in-flight non-completion requests for now until
we have a proper fix in place.
Resolves rdar://91251017.