Skip to content

stdlib: Remove some redundant generic requirements #42168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Apr 4, 2022

The GSB didn't emit warnings for these for some reason. There's no harm in leaving them in, but you'll get warnings now.

Proof that they're really redundant:

  • _ArrayBufferProtocol declares where Indices == Range<Int> already so there's no point restating it in the extension.
  • Result requires that Failure conform to Error which inherits from Sendable, so again it's redundant to restate in the extension.

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@airspeedswift airspeedswift requested a review from lorentey April 4, 2022 20:49
@slavapestov slavapestov merged commit 674a2aa into swiftlang:main Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants