Skip to content

[SILOpt] Added flag to disable destroy hoisting. #42197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2022
Merged

[SILOpt] Added flag to disable destroy hoisting. #42197

merged 1 commit into from
Apr 6, 2022

Conversation

nate-chandler
Copy link
Contributor

It is on by default. The default changes with the value of the CopyPropagation setting. But it can still be overridden.

@nate-chandler nate-chandler requested a review from atrick April 5, 2022 22:26
@nate-chandler nate-chandler force-pushed the destroy_hoisting/flag branch 2 times, most recently from e07b6ab to 944ccdf Compare April 6, 2022 02:28
atrick
atrick approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! That is some extremely thorough options testing.

@nate-chandler
[SILOpt] Added flag to disable destroy hoisting.
11e5c97 
It is on by default.  The default changes with the value of the
CopyPropagation setting.  But it can still be overridden.
@nate-chandler nate-chandler force-pushed the destroy_hoisting/flag branch from 944ccdf to 11e5c97 Compare April 6, 2022 03:01
@nate-chandler
Copy link
Contributor Author

@swift-ci please test and merge

@nate-chandler
Copy link
Contributor Author

It even caught a bug! The = was missing at the end of "enable-destroy-hoisting" in

def enable_destroy_hoisting :
    Joined<["-"], "enable-destroy-hoisting=">,
    HelpText<"Whether to enable destroy hoisting">,
    MetaVarName<"true|false">;

@swift-ci swift-ci merged commit b74b044 into swiftlang:main Apr 6, 2022
@nate-chandler nate-chandler deleted the destroy_hoisting/flag branch July 5, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrick atrick atrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nate-chandler @atrick @swift-ci