[move-function-dbginfo] Modify a test slightly to fix the arm64 bots and re-enable that test. #42261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and re-enable that test. The pattern started to fail here since the variable "m" is not a variable that we moved so as a result we use heuristics to determine if it should become an entry value. Noting that we only pattern match "m" to ensure that we can easily check the variable "k" afterwards (the thing that was actually moved), I just loosened the pattern so that we validate that we found "m" but do not check "m"'s location. This guarantees that on all platforms this will pattern match appropriately. rdar://91467528
|
@swift-ci test |
|
@swift-ci Please test Apple Silicon |
|
I tested this locally and made sure that Apple Silicon worked. I have been waiting for the macOS platform on apple silicon to start working for 2 hours... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern started to fail here since the variable "m" is not a variable that
we moved so as a result we use heuristics to determine if it should become an
entry value.
Noting that we only pattern match "m" to ensure that we can easily check the
variable "k" afterwards (the thing that was actually moved), I just loosened the
pattern so that we validate that we found "m" but do not check "m"'s
location. This guarantees that on all platforms this will pattern match
appropriately.
rdar://91467528