-
Notifications
You must be signed in to change notification settings - Fork 10.5k
IRGen: disable class fast casting on Windows #42265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRGen: disable class fast casting on Windows #42265
Conversation
@swift-ci smoke test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please link the radar that tracks this? I don't want this to slip through the cracks
Thinking a bit more, would it make more sense to make this Darwin vs non-Darwin? That way we can have some sort of comparison point between platforms. I know that @shahmishal has been pushing for more homogenous builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this disables it on the Windows host - we should disable this by target configuration and for !Apple targets.
It causes some problems on CI.
df0cf90
to
e9cc5d3
Compare
@compnerd you are right, it needs to be checked for the target. I changed that and added a link to the Jira. |
@swift-ci smoke test |
I think that this really does deserve a radar - Windows is a supported platform and disabling optimizations without any plans to re-enable them is not going to help Swift scale up. Could you also please include any notes from your investigation on the failure? |
@swift-ci please test Windows platform |
@swift-ci please build toolchain Windows platform |
1 similar comment
@swift-ci please build toolchain Windows platform |
I added investigation notes to the SR: https://bugs.swift.org/browse/SR-16112 |
If it is reasonable, I think that #42286 might be preferable - it keeps the optimization enabled. |
It causes some problems on CI.