Skip to content

IRGen: disable class fast casting on Windows #42265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

eeckstein
Copy link
Contributor

It causes some problems on CI.

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@eeckstein eeckstein requested review from etcwilde and compnerd April 8, 2022 19:35
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please link the radar that tracks this? I don't want this to slip through the cracks

@compnerd
Copy link
Member

compnerd commented Apr 8, 2022

Thinking a bit more, would it make more sense to make this Darwin vs non-Darwin? That way we can have some sort of comparison point between platforms. I know that @shahmishal has been pushing for more homogenous builds.

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this disables it on the Windows host - we should disable this by target configuration and for !Apple targets.

It causes some problems on CI.
@eeckstein eeckstein force-pushed the disable-fast-casting-on-windows branch from df0cf90 to e9cc5d3 Compare April 9, 2022 08:00
@eeckstein
Copy link
Contributor Author

@compnerd you are right, it needs to be checked for the target. I changed that and added a link to the Jira.
I don't want to disable it for Linux, though, because linux tests didn't show any problem.

@eeckstein
Copy link
Contributor Author

@swift-ci smoke test

@compnerd
Copy link
Member

compnerd commented Apr 9, 2022

I think that this really does deserve a radar - Windows is a supported platform and disabling optimizations without any plans to re-enable them is not going to help Swift scale up. Could you also please include any notes from your investigation on the failure?

@compnerd
Copy link
Member

compnerd commented Apr 9, 2022

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Apr 9, 2022

@swift-ci please build toolchain Windows platform

1 similar comment
@compnerd
Copy link
Member

@swift-ci please build toolchain Windows platform

@atrick
Copy link
Contributor

atrick commented Apr 10, 2022

I added investigation notes to the SR: https://bugs.swift.org/browse/SR-16112

@compnerd
Copy link
Member

If it is reasonable, I think that #42286 might be preferable - it keeps the optimization enabled.

@eeckstein eeckstein closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants