[CodeCompletion] Migrate postfix expr completion to solver-based #42280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/migrate-postfix-completion-solver-based
branch
2 times, most recently
from
11be747 to
ae5bb41
Compare
# Conflicts: # include/swift/Sema/IDETypeChecking.h # lib/IDE/CodeCompletion.cpp # test/IDE/complete_enum_elements.swift # test/IDE/complete_value_expr.swift
# Conflicts: # lib/IDE/CodeCompletion.cpp
Fixed by adding
```
if (ctx.CompletionContext) {
options |= ConstraintSystemFlags::ForCodeCompletion;
}
```
in BuilderTransform.cpp:1581 (after `ConstraintSystemOptions options = ConstraintSystemFlags::AllowFixes`)
ahoppen
force-pushed
the
pr/migrate-postfix-completion-solver-based
branch
from
ae5bb41 to
740075d
Compare
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please SourceKit stress test |
|
This is now part of #63717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.