Refactoring 1_stdlib/Optional.swift test file #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protocol TestProtocol1 {} | ||
|
|
||
| // Check that the generic parameter is called 'Memory'. | ||
| extension Optional where Wrapped : TestProtocol1 { | ||
| extension Optional where Wrapped: TestProtocol1 { |
There was a problem hiding this comment.
In the standard library code, we put spaces on both sides of the colon when it denotes an "is-a" relationship: in generic parameter lists, in inheritance and protocol implementation lists etc.
frootloops
force-pushed
the
stdlib-unittest
branch
from
8afa44a to
f2fd81f
Compare
|
@gribozavr thanks for review. Can you look again :) |
|
Whats about |
|
|
|
@gribozavr |
|
@frootloops Yes, |
|
@gribozavr ok, thanks. |
|
@gribozavr is PR ready for merge? |
| // CHECK-NEXT: false, true, false, false, true, false. | ||
| expectEqual(testRelation(==), [true, false, false, false, false, true]) | ||
| expectEqual(testRelation(!=), [false, true, true, true, true, false]) | ||
| expectEqual(testRelation(<), [false, true, false, false, true, false]) |
There was a problem hiding this comment.
Please move this into an OptionalTest.test() {}, there should be no top-level code.
frootloops
force-pushed
the
stdlib-unittest
branch
from
f2fd81f to
bb307a7
Compare
frootloops
force-pushed
the
stdlib-unittest
branch
from
bb307a7 to
ea46807
Compare
|
@gribozavr I have update the PR. Thank you for comments 👍 |
gribozavr
added a commit
that referenced
this pull request
Dec 11, 2015
Refactoring 1_stdlib/Optional.swift test file
|
@frootloops Thank you! |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift
that referenced
this pull request
Mar 20, 2020
[pull] swiftwasm from master
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add support for release/5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can somebody have a look at the PR and leave some comments and advices about code style, variable naming etc.
I use
./llvm/utils/lit/lit.py -sv ./build/Ninja-DebugAssert/swift-macosx-x86_64/test-macosx-x86_64/1_stdlib/Optional.swiftfor running tests. Is it right way to do so?