[5.7][stdlib] Add Clock.Duration as an associated type requirement
#42316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As [discussed on the forum][forum], we'll likely want to use `Duration` as the primary associated type on `protocol Clock`; however, that protocol currently only has `Instant`. [forum]: https://forums.swift.org/t/pitch-primary-associated-types-in-the-standard-library/56426/39 To support declaring it as the primary associated type, `protocol Clock` needs to have `Duration` as an associated type requirement: ``` @available(SwiftStdlib 5.7, *) public protocol Clock: Sendable { associatedtype Duration: DurationProtocol associatedtype Instant: InstantProtocol where Instant.Duration == Duration var now: Instant { get } var minimumResolution: Instant.Duration { get } func sleep(until deadline: Instant, tolerance: Instant.Duration?) async throws } ``` This setup is reminiscent of `Sequence.Element` vs. `Sequence.Iterator.Element`. SE-0329 has not yet shipped in an ABI stable release, so we still have the opportunity to address this. rdar://91591545 (cherry picked from commit 0aadfb0)
lorentey
added
the
swift evolution pending discussion
|
|
|
@swift-ci test |
lorentey
added
swift evolution approved
|
(swiftlang/swift-evolution#1618 is merged now) |
stephentyrone
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from #42314, commit 0aadfb0)
As discussed on the forum, we'll likely want to use
Durationas the primary associated type onprotocol Clock; however, that protocol currently only hasInstant.To support declaring it as the primary associated type,
protocol Clockneeds to haveDurationas an associated type requirement:This setup is reminiscent of
Sequence.Elementvs.Sequence.Iterator.Element.SE-0329 has not yet shipped in an ABI stable release, so we still have the opportunity to address this.
rdar://91591545