[BuilderTransform] Replace use of TypeExpr with a special $builderSelf variable
#42329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
Apr 15, 2022
|
@swift-ci please test |
|
Can we call it |
|
Or just |
…f variable For all of the `build*` calls, let's use a special variable declaration `$builderSelf` which refers to a type of the builder used. This allows us to remove hacks related to use of `TypeExpr`. Reference to `$builderSelf` is replaced with `TypeExpr` during solution application when the builder type is completely resolved.
xedin
changed the title
TypeExpr with a special __builderSelf variableTypeExpr with a special $builderSelf variable
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all of the
build*calls, let's use a special variable declaration$builderSelfwhich refers to a type of the builder used. This allowsus to remove hacks related to use of
TypeExpr. Reference to$builderSelfis replaced with
TypeExprduring solution application when the buildertype is completely resolved.