Skip to content

Revert "runtime: allow over-aligned types in the runtime" #42345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "runtime: allow over-aligned types in the runtime" #42345

wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

Reverts #42143

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd mentioned this pull request Apr 13, 2022
Closed
@finagolfin
Copy link
Member

Btw, reverting this alone won't be enough for Android armv7, as the earlier #42130 also doesn't compile for the 32-bit target.

@compnerd compnerd closed this Apr 14, 2022
@compnerd compnerd deleted the revert-42143-malign branch April 14, 2022 00:58
@compnerd
Copy link
Member Author

I believe that #42358 should repair the android ambiguity - that seems legitimate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeash mikeash Awaiting requested review from mikeash mikeash will be requested when the pull request is marked ready for review mikeash is a code owner

@al45tair al45tair Awaiting requested review from al45tair al45tair will be requested when the pull request is marked ready for review al45tair is a code owner

@ktoso ktoso Awaiting requested review from ktoso ktoso will be requested when the pull request is marked ready for review ktoso is a code owner

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall will be requested when the pull request is marked ready for review rjmccall is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compnerd @finagolfin