[Test] Make allocator_sanity.swift more robust on 32-bit. #42346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test attempts to allocate Int.max bytes and asserts that it crashes. However, this can actually succeed in (some) 32-bit environments, since Int.max is only 2^32-1 bytes there. This causes spurious test failures. Ensure the test crashes by making two gargantuan allocations. rdar://91687691
|
@swift-ci please test and merge |
grynspan
reviewed
Apr 13, 2022
| // There is a chance that we'll actually be able to allocate Int.max bytes on | ||
| // 32-bit platforms, since they often have 4GB address spaces and Int.max is | ||
| // 2GB minus one byte. Allocate twice to ensure failure. That will (attempt | ||
| // to) allocate 4GB minus two bytes, and we'll definitely have more than two |
There was a problem hiding this comment.
Unless the platform uses separate address spaces for code and data, in which case…
There was a problem hiding this comment.
If we find a situation where the system has less than three bytes allocated when this test runs, we can revisit it then. 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test attempts to allocate Int.max bytes and asserts that it crashes. However, this can actually succeed in (some) 32-bit environments, since Int.max is only 2^32-1 bytes there. This causes spurious test failures. Ensure the test crashes by making two gargantuan allocations.
rdar://91687691