Skip to content

[CursorInfo] Add ObjC location to generated symbol graph #42353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

bnbarham
Copy link
Contributor

Add the file for an imported ObjC-symbol to the generated symbol graph
when ObjC documentation is requested.

Skips line/column information for now since it's not needed. If we add
those we should extract location retrieval to a common method for both
cursor info and symbol graph gen.

Resolves rdar://91658873.

Add the file for an imported ObjC-symbol to the generated symbol graph
when ObjC documentation is requested.

Skips line/column information for now since it's not needed. If we add
those we should extract location retrieval to a common method for both
cursor info and symbol graph gen.

Resolves rdar://91658873.
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@QuietMisdreavus is there any way to pass those symbol graph options down from symbolgraph-extract? I was thinking it'd probably be better to move these tests into SymbolGraph and then have cursor info just test the very basics. Can do that in a later PR though.

@QuietMisdreavus
Copy link
Contributor

@bnbarham If you want to set an option directly in swift-symbolgraph-extract, you'll need to add a CLI flag for it. There's a section of symbol-graph-specific options in Options.td, so you should be able to add one there and load it just in swift_symbolgraph_extract_main.cpp.

@bnbarham
Copy link
Contributor Author

@bnbarham If you want to set an option directly in swift-symbolgraph-extract, you'll need to add a CLI flag for it. There's a section of symbol-graph-specific options in Options.td, so you should be able to add one there and load it just in swift_symbolgraph_extract_main.cpp.

Ah nice, thanks! I'll refactor those tests in a separate PR later.

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

Copy link
Contributor

@ethan-kusters ethan-kusters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bnbarham
Copy link
Contributor Author

@swift-ci please test macOS platform

@bnbarham bnbarham merged commit 1d97379 into swiftlang:main Apr 14, 2022
@bnbarham bnbarham deleted the add-objc-loc branch April 14, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants