Skip to content

[5.7][CursorInfo] Add ObjC location to generated symbol graph #42356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

bnbarham
Copy link
Contributor

Cherry-pick 680bf2e


Add the file for an imported ObjC-symbol to the generated symbol graph
when ObjC documentation is requested.

Skips line/column information for now since it's not needed. If we add
those we should extract location retrieval to a common method for both
cursor info and symbol graph gen.

Resolves rdar://91658873.

Add the file for an imported ObjC-symbol to the generated symbol graph
when ObjC documentation is requested.

Skips line/column information for now since it's not needed. If we add
those we should extract location retrieval to a common method for both
cursor info and symbol graph gen.

Resolves rdar://91658873.
@bnbarham bnbarham requested a review from airspeedswift April 14, 2022 00:31
@bnbarham bnbarham requested a review from a team as a code owner April 14, 2022 00:31
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham bnbarham changed the title [CursorInfo] Add ObjC location to generated symbol graph [5.7][CursorInfo] Add ObjC location to generated symbol graph Apr 14, 2022
@bnbarham bnbarham added the r5.7 label Apr 14, 2022
@bnbarham
Copy link
Contributor Author

@swift-ci please test Linux platform

@bnbarham
Copy link
Contributor Author

@swift-ci please clean test Linux platform

@bnbarham
Copy link
Contributor Author

swiftlang/swift-integration-tests#100

@swift-ci please test Linux platform

@bnbarham
Copy link
Contributor Author

Linux failure is unrelated (seems to be caused by swiftlang/swift-docc#136 but not clear as to why).

@bnbarham bnbarham merged commit f2cfe49 into swiftlang:release/5.7 Apr 14, 2022
@bnbarham bnbarham deleted the cherry-objc-loc branch April 14, 2022 23:56
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants