[5.7][stdlib] Fix nullability logic of memcmp
#42359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finagolfin
reviewed
Apr 15, 2022
| #if defined(__APPLE__) || defined(__ANDROID__) || defined(__OpenBSD__) | ||
| extern int memcmp(const void * _Nullable, const void * _Nullable, __swift_size_t); | ||
| // FIXME: Is there a way to identify Glibc specifically? | ||
| #if defined(__gnu_linux__) |
There was a problem hiding this comment.
I used __GLIBC__ before, doesn't that work?
There was a problem hiding this comment.
No, because the shim doesn’t (and cannot, I suppose) include any header from Glibc, so any Glibc-defined macros seem not available.
|
Anyone to test & merge? |
|
It is Sunday morning in California, you may have to wait a day. |
|
Ping @stephentyrone |
|
@xymus, would you review? |
|
@swift-ci please smoke test |
|
@swift-ci please test |
stephentyrone
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #41797 into Swift 5.7 release branch.
Fix the nullability judging logic for
extern int memcmpinLibcShims.h.