Skip to content

[Test] Fix broken IDE test #42370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

[Test] Fix broken IDE test #42370

merged 1 commit into from
Apr 14, 2022

Conversation

bnbarham
Copy link
Contributor

complete_in_result_builder.swift was modified in
0b9644a but ended up being merged
after 5d01a09 which removed the
Identical type relation entirely.

Replace the two added test cases with Convertible instead.

@bnbarham
[Test] Fix broken IDE test
52d224c 
`complete_in_result_builder.swift` was modified in
0b9644a but ended up being merged
*after* 5d01a09 which removed the
`Identical` type relation entirely.

Replace the two added test cases with `Convertible` instead.
@bnbarham bnbarham requested review from ahoppen and rintaro April 14, 2022 18:50
@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@jckarter jckarter mentioned this pull request Apr 14, 2022
Merged
@milseman
Copy link
Member

Merging to unblock CI

@milseman milseman merged commit 94623f0 into swiftlang:main Apr 14, 2022
@bnbarham bnbarham deleted the fix-broken-test branch April 14, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen Awaiting requested review from ahoppen

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @milseman