5.7 fix cast ownership #42378
Merged
5.7 fix cast ownership #42378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit fd84606)
Added an AST helper in Types.h: - isPotentiallyAnyObject() This formalizes logic for when cast operations forward ownership. Various OSSA optimization rely on this for correctness. This fixes latent bugs throughout the optimizer. I was compelled to fix this now because we want to make OSSA optimizations across dynamic casts more aggressive. For example, we want to optimize retain/release across enum formation. (cherry picked from commit 1a9c2ad)
(cherry picked from commit 90ec837)
Allow borrowed class-to-AnyObject scalar casts. (cherry picked from commit 16e5fe9)
(cherry picked from commit 64ec981)
Use the new API that determines whether a cast preserves ownership. Remove an old hack. (cherry picked from commit a7c6a94)
|
@swift-ci test |
|
Linux error: |
|
@swift-ci test linux |
|
@eeckstein @tbkka these changes, taken together, should prevent the generation of ownership-guaranteed casts from This SIL becomes illegal, as it should be: I'm cherry-picking this back to 5.7 because @eeckstein found this case occurring in a real project. Without these changes, the compiler ignores the SIL above, potentially miscompiling, until the function is specialized. Only when |
|
@tbkka hello branch manager |
|
@tbkka waiting for branch manager review |
tbkka
approved these changes
Apr 18, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://91768775 (crash when specializing a cast for AnyObject)