Skip to content

[5.7][CodeCompletion] Ensure synthesized members are available before lookup #42397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

[5.7][CodeCompletion] Ensure synthesized members are available before lookup #42397

merged 1 commit into from
Apr 25, 2022
+50 −28

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Apr 15, 2022 •
edited
Loading

Cherry-pick #41735 into release/5.7

  • Explanation: For non-solver based code completion, when looking up members for a type, some implicit members weren't populated. Ensure the implicit members that has the requested name available by force triggering the synthesis before lookups
  • Scope: Code completion that is still using legacy ExprContextAnalyzer (completion right after paren for call expr, and completion at multiple trailing closure label position).
  • Issues: rdar://89773376
  • Risk: Low.
  • Testing: Added regression test cases
  • Reviewer: Ben Barham (@bnbarham)

@rintaro rintaro requested a review from a team as a code owner April 15, 2022 21:42
@rintaro
Copy link
Member Author

rintaro commented Apr 15, 2022

@swift-ci Please test

@rintaro rintaro requested a review from airspeedswift April 15, 2022 21:53
@rintaro
[CodeCompletion] Ensure synthesized members are available before lookup
979035a 
In ExprContextAnalyzer, when looking up members, some implicit
members weren't populated. Ensure all implicit members available by
force synthesizing them.

rdar://89773376
(cherry picked from commit 4e62140)
@rintaro rintaro force-pushed the 5.7-ide-completion-rdar89773376 branch from 74665b2 to 979035a Compare April 21, 2022 17:20
@rintaro
Copy link
Member Author

rintaro commented Apr 21, 2022

@swift-ci Please test

@DougGregor DougGregor merged commit 31967c6 into swiftlang:release/5.7 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor