Skip to content

Sema: Don't require properties to have initializers in classes in module interfaces #42408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tshortli
Copy link
Contributor

Avoid requiring properties to have initializers in @requires_stored_property_inits classes when type checking module interfaces. Most initializers are not printed in interfaces so enforcing this requirement in that context doesn't make sense.

Resolves rdar://91505142

@tshortli tshortli marked this pull request as draft April 16, 2022 03:10
@tshortli tshortli force-pushed the dont-require-initial-values-in-interfaces branch from 0e31da4 to a8060c1 Compare April 16, 2022 03:14
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli changed the title Sema: Don't properties to have initializers in @requires_stored_property_inits classes in module interfaces Sema: Don't require properties to have initializers in classes in module interfaces Apr 16, 2022
…tored_property_inits` classes when type checking module interfaces. Most initializers are not printed in interfaces so enforcing this requirement in that context doesn't make sense.

Resolves rdar://91505142
@tshortli tshortli force-pushed the dont-require-initial-values-in-interfaces branch from a8060c1 to 826cc9d Compare April 18, 2022 16:12
@tshortli
Copy link
Contributor Author

@swift-ci please smoke test

@tshortli tshortli marked this pull request as ready for review April 18, 2022 16:13
@tshortli tshortli requested review from xymus and nkcsgexi April 18, 2022 16:14
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tshortli tshortli merged commit 60ca648 into swiftlang:main Apr 18, 2022
@tshortli tshortli deleted the dont-require-initial-values-in-interfaces branch May 8, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants