[cxx-interop] Import complex inferred dependent return types #42411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test. |
cabmeurer
force-pushed
the
cabmeurer/import-complex-inferred-dependent-return-types
branch
from
94a781c to
e2b69e4
Compare
zoecarver
reviewed
Apr 27, 2022
zoecarver
reviewed
Apr 27, 2022
|
@swift-ci please test. |
|
@zoecarver tested out your suggestions and left comments, for some reason the Linux smoke test hasn't run? |
|
@swift-ci test Linux |
|
@swift-ci test Windows |
zoecarver
reviewed
May 9, 2022
cabmeurer
force-pushed
the
cabmeurer/import-complex-inferred-dependent-return-types
branch
from
e2b69e4 to
3810951
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows |
cabmeurer
force-pushed
the
cabmeurer/import-complex-inferred-dependent-return-types
branch
2 times, most recently
from
19290b9 to
9f499c8
Compare
|
@swift-ci please test |
|
@zoecarver some weirdness going on with windows ?? |
|
@swift-ci please test windows |
|
I keep forgetting to look at the logs, sorry. |
|
This LGTM. As soon as the tests pass I'll merge it! |
|
@zoecarver thank you!! Any idea why this would fail on windows or how I can debug this??? |
zoecarver
reviewed
May 16, 2022
cabmeurer
force-pushed
the
cabmeurer/import-complex-inferred-dependent-return-types
branch
from
9f499c8 to
2f8c32c
Compare
|
@swift-ci please test. |
|
Thanks, Caleb! Happy to finally get this landed. |
Thank you! |
cabmeurer
deleted the
cabmeurer/import-complex-inferred-dependent-return-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for importing Cxx methods that have inferred dependent return types to be the swift
AnytypeRelated to: SR-13809
@zoecarver @hyp