[Distributed] Invoking distributed func defined via extension crashes on x86

[ktoso]

Resolves rdar://91888361

Making sure such calls still call the remote impl and don't get tricked by the existential.
This is super important that this always works, so making sure by including the tests.

[ktoso]

@swift-ci please smoke test

[DougGregor]

@swift-ci please smoke test

[ktoso]

This does crash indeed... Wait, I'm confused... This did crash on Linux CI now, but does not crash on my mac -- something weird happening 🤔 Will verify with a debug build on linux in a bit.

[ktoso]

I believe this #58745 might also fix this -- Checking...

[ktoso]

This is now crashing like:

+ /usr/bin/env DYLD_LIBRARY_PATH=/Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/lib/swift/macosx /Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/test-macosx-x86_64/Distributed/Runtime/Output/distributed_actor_hop_to.swift.tmp/a.out
+ /usr/local/bin/python3 /Users/ktoso/code/swift-project/swift/utils/PathSanitizingFileCheck --allow-unused-prefixes --sanitize BUILD_DIR=/Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64 --sanitize SOURCE_DIR=/Users/ktoso/code/swift-project/swift --use-filecheck /Users/ktoso/code/swift-project/build/Ninja-RelWithDebInfoAssert/llvm-macosx-x86_64/bin/FileCheck /Users/ktoso/code/swift-project/swift/test/Distributed/Runtime/distributed_actor_hop_to.swift --color
objc[15800]: autorelease pool page 0x1089a9000 corrupted
  magic     0x00000010 0x00000000 0x0898b11c 0x00000001
  should be 0xa1a1a1a1 0x4f545541 0x454c4552 0x21455341
  pthread   0x0
  should be 0x700005bbd000

[ktoso]

(I believe this was fixed along other issues, will try to confirm soon)

[ktoso]

@swift-ci please test

[ktoso]

It only fails on optimized build it seems.

[ktoso]

bad:

lit.py: /home/build-user/swift/test/lit.cfg:2620: note: Available features: CMAKE_GENERATOR=Ninja, CODEGENERATOR=AArch64, CODEGENERATOR=ARM, CODEGENERATOR=Mips, CODEGENERATOR=PowerPC, CODEGENERATOR=SystemZ, CODEGENERATOR=X86, CPU=x86_64, OS=linux-gnu, PTRSIZE=64, SWIFT_VERSION=4, VENDOR=unknown, asan_runtime, asserts, autolink-extract, bootstrapping_mode, concurrency, concurrency_runtime, cplusplus_driver, crash-recovery, differentiable_programming, distributed, executable_test, fuzzer_runtime, lld_lto, lldb, long_test, no_asan, no_lto, optimized_stdlib, optimized_stdlib_x86_64, reflection, scudo_runtime, shell, sourcekit, standalone_build, static_stdlib, stress_test, string_processing, swift-remoteast-test, swift_in_compiler, swift_interpreter, swift_only_stable_abi, swift_stdlib_no_asserts, swift_test_mode_optimize, swift_test_mode_optimize_x86_64, thread_safe_runtime, threading_linux, tools-release, ubsan_runtime

but passes on: lit.py: /home/build-user/swift/test/lit.cfg:2620: note: Available features: CMAKE_GENERATOR=Ninja, CODEGENERATOR=AArch64, CODEGENERATOR=ARM, CODEGENERATOR=Mips, CODEGENERATOR=PowerPC, CODEGENERATOR=SystemZ, CODEGENERATOR=X86, CPU=x86_64, OS=linux-gnu, PTRSIZE=64, SWIFT_VERSION=4, VENDOR=unknown, asan_runtime, asserts, autolink-extract, bootstrapping_mode, concurrency, concurrency_runtime, cplusplus_driver, crash-recovery, differentiable_programming, distributed, executable_test, fuzzer_runtime, lld_lto, lldb, long_test, no_asan, no_lto, nonexecutable_test, optimized_stdlib, optimized_stdlib_x86_64, reflection, scudo_runtime, shell, sourcekit, standalone_build, static_stdlib, stress_test, string_processing, swift-remoteast-test, swift_in_compiler, swift_interpreter, swift_only_stable_abi, swift_stdlib_no_asserts, swift_test_mode_optimize_none, swift_test_mode_optimize_none_x86_64, thread_safe_runtime, threading_linux, tools-release, ubsan_runtime

which is

[ktoso]

This was fixed a while back it seems