Skip to content

[SILOpt] Make sure that dynamically replaced function is kept alive #42453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

[SILOpt] Make sure that dynamically replaced function is kept alive #42453

merged 1 commit into from
Apr 20, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 19, 2022

Don't really know how to test this properly, noticed while working on #42252.

@xedin xedin requested a review from aschwaighofer April 19, 2022 19:09
aschwaighofer
aschwaighofer approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dynamically replaced function declaration/definition should be kept alive by such a reference.

This LGTM.

@xedin
Copy link
Contributor Author

xedin commented Apr 19, 2022

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Apr 19, 2022

@swift-ci please test Windows platform

2 similar comments
@xedin
Copy link
Contributor Author

xedin commented Apr 19, 2022

@swift-ci please test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Apr 20, 2022

@swift-ci please test Windows platform

ktoso
ktoso approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, makes sense same as distributed 👍

@xedin xedin merged commit 34db837 into swiftlang:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xedin @ktoso @aschwaighofer