Skip to content

[build-presets] Re-enable SourceKit-LSP tests on Linux #42479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Apr 20, 2022

I haven’t been able to reproduce the test failure after running it 200 times locally. I think it’s been fixed in the meantime.

rdar://90437872

@ahoppen
Copy link
Member Author

ahoppen commented Apr 20, 2022

@swift-ci Please smoke test

@ahoppen ahoppen requested a review from tomerd April 20, 2022 09:50
@hamishknight
Copy link
Contributor

Note we were also seeing failures in rdar://89359439, and I added another skip-test-sourcekit-lsp in #42083

I haven’t been able to reproduce the test failure after running it 200 times locally. I think it’s been fixed in the meantime.

rdar://90437872
@ahoppen ahoppen force-pushed the pr/re-enable-sourcekitlsp-tests branch from b0ff92e to f69ff78 Compare April 21, 2022 13:48
@ahoppen
Copy link
Member Author

ahoppen commented Apr 21, 2022

@swift-ci Please smoke test

@ahoppen ahoppen merged commit f91f956 into swiftlang:main Apr 22, 2022
@ahoppen ahoppen deleted the pr/re-enable-sourcekitlsp-tests branch April 22, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants