[SILGen] Use opaque AP for ObjC-async returns. #42485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the AbstractionPattern that was used for the value "returned" (i.e. via a completion handler) from ObjC mostly (but not quite always) was "type". The generated completion handler correctly (because this is required in order to call _resumeUnsafeContinuation) reabstracted the block (e.g. from @convention(block) to @Substituted <T> () -> @out T for <()>). The callee of the ObjC function, however, loaded the function from the block as if it were not reabstracted (e.g. () -> ()). On most platforms, that happened to work. On arm64e, that difference in types caused in a difference in pointer signing, resulting in a failure at runtime. rdar://85526879 rdar://85526916
|
@swift-ci please test |
|
@swift-ci Please test Apple Silicon macOS Platform |
|
@swift-ci please test macOS platform |
jckarter
approved these changes
Apr 20, 2022
|
Definitely! Actually the execution tests do call through the function value that's returned. That's what was failing on arm64e. For example, |
|
Interesting that that wouldn't crash on other platforms already too. Maybe an execution test that passes through a function with nontrivial arguments and returns would be more likely to expose the mismatch. |
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Apr 20, 2022
Verify the recent fix at swiftlang#42485.
|
Added more execution tests which return differently shaped function pointers in #42508 . |
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Apr 21, 2022
Verify the recent fix at swiftlang#42485.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the AbstractionPattern that was used for the value "returned" (i.e. via a completion handler) from ObjC mostly (but not quite always) was "type".
The generated completion handler correctly (because this is required in order to call
_resumeUnsafeContinuation)reabstracted the block (e.g. from@convention(block) () -> ())to@substituted <T> () -> @out T for <()>). The callee of the ObjC function, however, loaded the function from the block as if it were not reabstracted (e.g.() -> ()).On arm64e, that difference in types caused in a difference in pointer signing, resulting in a failure at runtime.
rdar://85526879
rdar://85526916