[5.7-04182022][Distributed] Retain ad-hoc decodeNextArgument in distributed thunk
#42495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIL has to force emission of `decodeNextArgument` and its retainment, so IRGen can reference it in distributed function accessor. (cherry picked from commit 79ad927) (cherry picked from commit 870c712) (cherry picked from commit dadf301) (cherry picked from commit 4e2c059) (cherry picked from commit 560e96f) (cherry picked from commit 41a4cea) (cherry picked from commit 8c8360a) (cherry picked from commit fc662bc) (cherry picked from commit 1d230ee)
|
@swift-ci please test |
ktoso
approved these changes
Apr 20, 2022
hborla
approved these changes
Apr 20, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #42252
SIL has to force emission of
decodeNextArgumentand its retainment,so IRGen can reference it in distributed function accessor, otherwise it
wouldn't be possible to use any type expect to a
classto implementa
DistributedInvocationDecoderprotocol which limits the use of thefeature significantly.
Scope: Types implementing
DistributedInvocationDecoderprotocol.Main Branch PR: [Distributed] retain ad-hoc witnesses so that they are not optimized away in SIL #42252
5.7 Branch PR: [5.7][Distributed] Retain ad-hoc
decodeNextArgumentin distributed thunk #42451Resolves: rdar://88211172
Risk: Very low
Reviewed By: @ktoso, @hborla
Testing: Added regression test-cases to the suite.
Resolves: rdar://88211172
(cherry picked from commit 79ad927)
(cherry picked from commit 870c712)
(cherry picked from commit dadf301)
(cherry picked from commit 4e2c059)
(cherry picked from commit 560e96f)
(cherry picked from commit 41a4cea)
(cherry picked from commit 8c8360a)
(cherry picked from commit fc662bc)
(cherry picked from commit 1d230ee)