Skip to content

Spelling dev docs #42517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 4, 2022
Merged

Spelling dev docs #42517

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5f0594
spelling: diagnostics
jsoref Apr 17, 2022
4d4ab69
spelling: distinguish
jsoref Apr 17, 2022
197829c
spelling: ingests
jsoref Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/Migrator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Here are the passes:

- API Diff Pass

This pass injests an *API Diff Data File*, a JSON file describing API changes
This pass ingests an *API Diff Data File*, a JSON file describing API changes
from the previous SDK, and looks for API references, performing textual edits
to update code for things like referenced type and argument names or optionality
changes. This is where the majority of changes come from in the Migrator.
Expand Down Expand Up @@ -81,7 +81,7 @@ Here are the passes:
- Tuple Splat Migrator Pass

This implements a few convenience transformations to ease the transition
for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distingish-single-tuple-arg.md).
for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distinguish-single-tuple-arg.md).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also depends on swiftlang/swift-evolution#1624


In particular, this pass adds new variable bindings in closure expressions
to destructure what are now are a single argument, a tuple. Prior to SE-0110,
Expand Down Expand Up @@ -133,7 +133,7 @@ Other controls for the frontend:

For the pre- and post-fix-it passes, there are two basic rules for which fix-its the Migrator will take:

1. Fix-its attached to *error* diagnosics are taken by default and are opt-out.
1. Fix-its attached to *error* diagnostics are taken by default and are opt-out.
2. Fix-its attached to *warning* or *note* diagnostics are not taken by default and so are opt-in.

For the opt-out and opt-in cases, these are filtered in the `FixitFilter`, essentially just a small collection of Swift's compiler diagnostic IDs.
Expand Down