Revert "Merge pull request #42242 from eeckstein/escapeinfo" #42562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @eeckstein @atrick |
|
@swift-ci please test |
|
@compnerd what regression? |
|
Anything else than the test fail, which is fixed by #42555? |
|
Never mind, I saw your comment in the other PR. Unfortunately the XFAIL for disabling the test is missing a ':' |
|
https://ci-external.swift.org/job/oss-swift-windows-toolchain-x86_64-vs2019/547/console Why should the test be an XFAIL? If you are XFAILing it, do you have a timeline for repairing it? |
|
The XFAIL was only the workaround from the build wrangler. The problem is a wrong check-pattern. I'll remove the XFAIL in my next attempt to land the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c05e064, reversing
changes made to c1534d5.
This caused a regression on Windows.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.