🍒5.7 [Distributed] clean up some of the initialization code to be more robust #42564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please build toolchain macOS |
|
@swift-ci please test |
ktoso
changed the title
ktoso
changed the title
ktoso
changed the title
|
Could we get a review here @DougGregor ? This is a cleanup @kavon did a while ago and I want main and 5.7 to be the same for all these synthesis bits so we don't run into weird "slighly off" bugs. |
DougGregor
approved these changes
May 10, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Cleanup for how we synthesize storing properties; reuse higher-level API to do this.
Original PR: #42557
Risk: Low
Testing: A lot of existing tests cover this storage and accessing, including SIL and runtime tests.
Since main toolchain builds are now broken, and we need to verify this.
Might resolve rdar://92142457