Skip to content

Prepare to (but does not) enable string processing by default. #42596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Apr 22, 2022

This is some groundwork to make it possible to flip the -enable-experimental-string-processing flag on by default if and when it passes Swift Evolution. This PR itself do not change the defaults.

  • Do not implicitly import _StringProcessing when building a module interface.
  • Do not implicitly import _StringProcessing when core libraries, same as _Concurrency.

This PR also removes -disable-implicit-distributed-module-import (7244f78). because Distributed is never implicitly imported.

This is some groundwork to make it possible to flip the `-enable-experimental-string-processing` flag on by default if and when it passes Swift Evolution. This PR itself do **not** change the defaults.

- Do not implicitly import _StringProcessing when building a module interface.
- Do not implicitly import _StringProcessing when core libraries, same as _Concurrency.
@rxwei rxwei requested review from ktoso and stephentyrone April 22, 2022 22:53
@rxwei
Copy link
Contributor Author

rxwei commented Apr 22, 2022

@swift-ci please test

Distributed is never implicitly imported.
@rxwei rxwei force-pushed the prepare-enable-string-processing branch from 84cdb0f to 7244f78 Compare April 22, 2022 23:01
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Apr 22, 2022
@rxwei
Copy link
Contributor Author

rxwei commented Apr 22, 2022

@swift-ci please test

@rxwei rxwei merged commit 35aa7f8 into swiftlang:main Apr 23, 2022
@rxwei rxwei deleted the prepare-enable-string-processing branch April 23, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants