🍒[5.7][Distributed] SILGen must consistently use prop get requests #42600
+43
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
changed the title
|
I'm not powerful enough to approve this :) |
ktoso
changed the title
DougGregor
approved these changes
Apr 23, 2022
|
@swift-ci please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: We must consistently use requests to get properties to avoid any potential chance of not looking up a property. This is mostly a cleanup though, did not cause issues in tests BUT it well could cause issues in larger real projects.
Risk: Low
Review by: @DougGregor @xedin
Testing: CI testing
Original PR: #42595
Radar: rdar://92162535