Fix UnsafeRawPointer.load to use Builtin.loadRaw. #4293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API should have been converted to use the new Builtin before it was introduced here: commit a41484e Author: Andrew Trick <[email protected]> Date: Fri Jul 22 13:32:08 2016 Add UnsafeRawPointer type and API. (#3677) But it looks like that was dropped during during some local merge. It's not likely to be a problem until developers start adopting the new API and the optimizer starts using TBAA aggressively. The other "raw" API's are binding memory or using memmove, so those are safe. rdar:23406272.
|
@swift-ci Please test OS X. |
|
@eeckstein please review this for inclusion in the 3.0 branch. Thanks. |
|
@swift-ci test linux |
|
LGTM |
kateinoigakukun
pushed a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API should have been converted to use the
new Builtin before it was introduced here:
commit a41484e
Author: Andrew Trick [email protected]
Date: Fri Jul 22 13:32:08 2016
Add UnsafeRawPointer type and API. (#3677)
But it looks like that was dropped during during some local merge. It's not
likely to be a problem until developers start adopting the new API and the
optimizer starts using TBAA aggressively. The other "raw" API's are binding
memory or using memmove, so those are safe.
rdar:23406272.