Fix for missing conformance with id-as-Any bridging #4298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test os x |
slavapestov
force-pushed
the
fix-for-missing-conformance
branch
from
77327cc to
fe228d9
Compare
|
@swift-ci Please smoke test os x |
1 similar comment
|
@swift-ci Please smoke test os x |
|
@swift-ci test os x |
|
@swift-ci test os x platform |
…ry when a nil literal is bridged When bridging values via the ObjectiveCBridgeable protocol, SILGen has to look up conformances directly, behind the type checker's back. To make sure the ObjectiveCBridgeable conformance is forced, Sema calls useObjectiveCBridgeableConformances() in the right places. However, another conformance we may also need when bridging is the Hashable conformance for a Set or Dictionary's key type. Make sure we force these too, because otherwise when bridging a nil literal nothing needs them in Sema. Fixes <rdar://problem/27470505>.
slavapestov
force-pushed
the
fix-for-missing-conformance
branch
from
fe228d9 to
56e2e13
Compare
|
@swift-ci Please smoke test os x |
1 similar comment
|
@swift-ci Please smoke test os x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.