Skip to content

[cmake] Rename COMPONENT_DEPENDS to LLVM_COMPONENT_DEPENDS #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

No description provided.

Now that I am going to be adding an IN_SWIFT_COMPONENT argument, I need to do
this to distinguish the concepts of an LLVM_COMPONENT and a SWIFT_COMPONENT.
@gottesmm
Copy link
Contributor Author

@swift-ci Please test OS X platform

@compnerd
Copy link
Member

Nice, this makes my head hurt less!

@gottesmm
Copy link
Contributor Author

@swift-ci Please smoke test os x

@gottesmm
Copy link
Contributor Author

@compnerd Being explicit is a general good IMO.

@gottesmm gottesmm merged commit b3819c6 into swiftlang:master Aug 16, 2016
@gottesmm gottesmm deleted the rename_componentdepends_to_llvmcomponentdepends branch August 16, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants