[Code Completion] Suffix ": " instead of "=" when completing attribute argument names #4313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
cc-attribute-colon
branch
from
001b55a to
c8e994e
Compare
| @@ -255,7 +255,7 @@ class CodeCompletionResultBuilder { | |||
| DeclAttrParamKeyword, Name); | |||
| if (NeedSpecify) | |||
| addChunkWithText(CodeCompletionString::Chunk::ChunkKind:: | |||
| DeclAttrParamEqual, "="); | |||
| DeclAttrParamEqual, ": "); | |||
There was a problem hiding this comment.
Should I rename DeclAttrParamEqual => DeclAttrParamColon ?
There was a problem hiding this comment.
Yes, please! And please update the doc comment above its declaration in CodeCompletion.h.
|
@swift-ci Please smoke test |
… argument names In addtion, renamed DeclAttrParamEqual to DeclAttrParamColon.
rintaro
force-pushed
the
cc-attribute-colon
branch
from
c8e994e to
81c1ede
Compare
|
Renamed @swift-ci Please smoke test |
|
macOS: |
|
@swift-ci Please smoke test |
|
For swift-3.0-branch: #4325 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
All named attribute parameters have been changed to use colon.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.