Skip to content

Fix affinetransform init #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

parkera
Copy link
Contributor

@parkera parkera commented Aug 16, 2016

What's in this pull request?

The migrator is changing NSAffineTransform() into AffineTransform(), but because AffineTransform is actually a renamed C struct (previously known as NSAffineTransformStruct), its initializer sets everything to zero.

This change removes that renaming and establishes AffineTransform as its own struct type, where we can control the behavior of the init function. The default initializer now returns an identity AffineTransform as expected.

Resolved bug number

rdar://problem/27793851 AffineTransform() and NSAffineTransform() initializers are not semantically equivalent


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@parkera
Copy link
Contributor Author

parkera commented Aug 16, 2016

Ugh, wrong branch. Will fix in a minute.

@parkera parkera changed the base branch from master to swift-3.0-branch August 16, 2016 21:39
@parkera
Copy link
Contributor Author

parkera commented Aug 16, 2016

@swift-ci please test and merge

@tkremenek
Copy link
Member

@swift-ci test

@tkremenek
Copy link
Member

@tkremenek tkremenek merged commit 38a0bbc into swiftlang:swift-3.0-branch Aug 17, 2016
@parkera parkera deleted the fix_affinetransform_init branch November 7, 2016 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants