[Import as Member] Inferred inits are factory #4335
Conversation
|
@swift-ci please test |
| @@ -2564,6 +2564,10 @@ auto ClangImporter::Implementation::importFullName( | |||
| else if (inference.isSetter()) | |||
| result.AccessorKind = ImportedAccessorKind::PropertySetter; | |||
|
|
|||
| // Inits are factory | |||
There was a problem hiding this comment.
Can you beef up this comment to explain why we need this?
|
Linux failure seems unrelated. I will update PR with better comments. |
Inferred inits from C via import-as-member are factory inits, so treat them as such. Core Graphics test case included.
milseman
force-pushed
the
import_as_member
branch
from
6344ad7 to
7b1ec7e
Compare
|
@swift-ci please smoke test |
|
Update was comment only, so just smoke test to gate PR |
|
@swift-ci test |
|
I think this should go into master, even if it is not a complete fix for the issue. Once we add factory init support to SILGen, this change will be a pre-requisite anyway. |
|
Why can't I see the builder status? |
|
It's been buggy lately. You can usually find it at https://ci.swift.org/view/Pull%20Request/, but then you'll have to get an admin to force-merge it (Ted or Ewa). |
|
Anywho, this passed a long time ago, and the only change was to a comment. It should be merge worthy. @tkremenek or @ematejska , do you want to run this through smoke test or merge? |
What's in this pull request?
Prior to this, developers could run into trouble if they defined their own init that called a inferred-import-as-member factory init, because we were not adequately setting the factory-ness.
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
Inferred inits from C via import-as-member are factory inits, so treat
them as such. Core Graphics test case included.