Skip to content

[FixCode] Apply coercion fixit for assignment types' mismatch too #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benlangmuir
Copy link
Contributor

What's in this pull request?

  • Explanation: We have a fixit for adding casts for type mismatches, but it's not being applied in assignments, which negatively impacts migration to swift-3.
  • Scope: Affects users assigning Any values into AnyObject variables. This is a fairly common migration situation after the id-as-Any changes.
  • Risk: Very low; just adds a switch case that was missed to an existing fixit.
  • Reviewed by: Ben Langmuir (patch by Xi with test fixup by Argyrios)
  • Testing: Regression test added.

Resolved bug number: (SR-)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

nkcsgexi and others added 4 commits August 16, 2016 19:00
…rop'.

This is because it depends on using AnyObject.
Keep the main test portable by moving the objc_interop bits into their
own test, combined with the existing selector tests.
@benlangmuir
Copy link
Contributor Author

@swift-ci Please test OS X platform

@tkremenek tkremenek merged commit 0b8f3e4 into swiftlang:swift-3.0-branch Aug 17, 2016
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Resolve build issues with upstream `main`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants