Skip to content

[gardening] Python tidies in cmpcodesize.main #4477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2016
Merged

[gardening] Python tidies in cmpcodesize.main #4477

merged 1 commit into from
Sep 1, 2016

Conversation

alexwlchan
Copy link
Contributor

What's in this pull request?

Some Python tidies:

  • Those .sorts weren't actually doing anything -- you need to call the methods for them to take effect.
  • Use zip(), and drop the idx variable. We know that old_files and new_files are the same length -- there's a check on the lines above -- so we don't need to worry about missing elements.

Resolved bug number: (SR-)

None.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

  • Actually call the sort() method.
  • Cut out an unnecessary idx variable.

* Actually call the `sort()` method.
* Cut out an unnecessary `idx` variable.
@CodaFi
Copy link
Contributor

CodaFi commented Aug 24, 2016

@swift-ci please Python lint.

@CodaFi
Copy link
Contributor

CodaFi commented Aug 24, 2016

CC @eeckstein for review.

@eeckstein
Copy link
Contributor

@swift-ci Please smoke test

@eeckstein eeckstein merged commit 24f422e into swiftlang:master Sep 1, 2016
@alexwlchan alexwlchan deleted the cmpcodesize-fix branch September 1, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants