[Type checker] Introduce directional path consistency algorithm #4485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPC algoritm tries to solve individual sub-expressions and combine resolved types as a way to reduce pre-existing OSR domains. Solving is done bottom-up so each consecutive sub-expression tightens possible solution domain even further.
|
/cc @DougGregor |
|
@swift-ci Smoke test macOS. |
|
@xedin We are seeing test failure on Linux: |
|
@shahmishal @rudkx I think it would be better to maybe figure out why MacOS allows to "import Foundation" and linux doesn't? I got that code from SR-2102, I can also restructure the test so it doesn't require it, since sin is what is contained in Foundation. |
|
Please revert for now so we can keep the bots happy. We can resubmit once the test is fixed. |
|
Swift tests aren't allowed to reference Foundation on Linux, because on Linux you should be able to run the tests without having built Foundation |
|
Thanks for clarification, @jrose-apple! I obviously didn't know that... Meanwhile I've reformatted the test and removed Foundation dependency with equivalent function overloads... Going to submit it as separate PR and link it here for reference as well. |
1 task
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
* Use Yams 4.0.2 to fix Ubuntu 18.04 build Currently, as can be seen from logs at https://github.com/swiftwasm/swift/runs/6178363121?check_suite_focus=true compilation of Yams fails with this error: ``` /home/runner/work/swift/swift/yams/Sources/Yams/YamlError.swift -Xlinker -soname -Xlinker libYams.so -L /home/runner/work/swift/swift/host-build/Ninja-Release/swiftpm-linux-x86_64/x86_64-unknown-linux-gnu/yams/lib -L /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib -L /usr/lib/gcc/x86_64-linux-gnu/7 -Xlinker -rpath -Xlinker /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib: lib/libCYaml.a -ldispatch /home/runner/work/swift/swift/host-build/Ninja-Release/foundation-linux-x86_64/lib/libFoundation.so -lswiftDispatch -lgcc -lgcc_s -lc -lgcc -lgcc_s && : 23585 /usr/bin/ld.gold: error: lib/libCYaml.a(api.c.o): requires dynamic R_X86_64_PC32 reloc against 'yaml_realloc' which may overflow at runtime; recompile with -fPIC 23586 /usr/bin/ld.gold: error: lib/libCYaml.a(scanner.c.o): requires dynamic R_X86_64_PC32 reloc against 'yaml_parser_fetch_more_tokens' which may overflow at runtime; recompile with -fPIC 23587 clang-13: error: linker command failed with exit code 1 (use -v to see invocation) 23588 <unknown>:0: error: link command failed with exit code 1 (use -v to see invocation) ``` * Use Yams 5.0.1 in `swiftwasm-release/5.7` scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Improvements to the TypeChecker, namely DPC
(directional path consistency) algoritm which tries to
solve individual sub-expressions and combine
resolved types as a way to reduce pre-existing OSR domains. Solving
is done bottom-up so each consecutive sub-expression tightens
possible solution domain even further.
Resolved bug number: (SR-139)
Resolved bug number: (SR-838)
Resolved bug number: (SR-2102)
And most likely at least couple of others related to "expression is too complex" I haven't seen yet.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
DPC algoritm tries to solve individual sub-expressions and combine
resolved types as a way to reduce re-existing OSR domains. Solving
is done bottom-up so each consecutive sub-expression tightens
possible solution domain even further.