Switch override checking over to access scopes. #4508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
| matchDecl->getModuleContext() != decl->getModuleContext() && | ||
| !isa<ConstructorDecl>(decl)) { | ||
| TC.diagnose(decl, diag::override_of_non_open, | ||
| decl->getDescriptiveKind()); | ||
| } else if (matchAccess == Accessibility::Open && !matchDecl->isFinal() && |
There was a problem hiding this comment.
sigh This is supposed to be decl. I knew I was forgetting a test case.
jrose-apple
force-pushed
the
override-access-scopes
branch
from
0a2c0f2 to
6dbb0b5
Compare
The class version of f65ad81. Fixes some incorrect diagnostics. We really do need https://bugs.swift.org/browse/SR-2209 to make this all cleaner. rdar://problem/27820665
jrose-apple
force-pushed
the
override-access-scopes
branch
from
6dbb0b5 to
9a217b5
Compare
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
|
@rjmccall, mind reviewing this? |
|
@rjmccall review ping |
|
LGTM. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 3, 2016
The class version of f65ad81. Fixes some incorrect diagnostics. We really do need https://bugs.swift.org/browse/SR-2209 to make this all cleaner. rdar://problem/27820665 (cherry picked from commit 8b1ce7d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class version of f65ad81. Fixes some incorrect diagnostics.
We really do need SR-2209 to make this all cleaner.
rdar://problem/27820665
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.