[ClangImporter] Predefine __swift__ in imported (Obj)C code. #4510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitjammer, this is your code I'm generalizing. Can you double-check that I did it right, especially since we don't have a good way to write tests for |
This macro expands to a numeric value representing the current Swift language version; for Swift 3.1.2, it would be 30102. See discussion in https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160822/002754.html. rdar://problem/26921435
|
@swift-ci Please test |
|
LGTM |
|
Looks reasonable to me, @jrose-apple. |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Aug 26, 2016
…ng#4510) This macro expands to a numeric value representing the current Swift language version; for Swift 3.1.2, it would be 30102. See discussion in https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160822/002754.html. rdar://problem/26921435 (cherry picked from commit 5ffb151)
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Jul 31, 2024
Leaving behind an un-versioned `__swift__` macro. Originally added in swiftlang#4510 (rdar://26921435) following a discussion in https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160822/002754.html, the versioned macro was used to allow clients primarily to ready their existing ObjectiveC code for Swift 2 -> Swift 3 transition. Now that neither one of those versions is a supported language mode and we have versioned APINotes support, and we do not currently know of clients that rely on the version carried by this macro, we would like to deprecate it, leaving behind the un-versioned `-D__swift__`. The reason for the deprecation is that it is likely that in a build with multiple targets which have very similar configuration aside from Swift language version, they would not be able to share module dependencies due to the mismatch in the macro value.
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Aug 1, 2024
Leaving behind an un-versioned `__swift__` macro. Originally added in swiftlang#4510 (rdar://26921435) following a discussion in https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160822/002754.html, the versioned macro was used to allow clients primarily to ready their existing ObjectiveC code for Swift 2 -> Swift 3 transition. Now that neither one of those versions is a supported language mode and we have versioned APINotes support, and we do not currently know of clients that rely on the version carried by this macro, we would like to deprecate it, leaving behind the un-versioned `-D__swift__`. The reason for the deprecation is that it is likely that in a build with multiple targets which have very similar configuration aside from Swift language version, they would not be able to share module dependencies due to the mismatch in the macro value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This macro expands to a numeric value representing the current Swift language version; for Swift 3.1.2, it would be 30102.
See discussion in https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160822/002754.html.
rdar://problem/26921435
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.