[CodeCompletion] Modifier related improvements in CompletionOverrideLookup #4518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
rintaro
force-pushed
the
cc-override-modifier
branch
from
f0c185e to
d7d3a1e
Compare
|
@swift-ci Please test |
|
@benlangmuir Could you review this? |
| if (hasInitializerModifier) | ||
| return; | ||
|
|
||
| if (!hasIntroducer || hasVarIntroducer) |
There was a problem hiding this comment.
If someone wrote required var or convenience func, etc. I suggest we still give them var and func override completions. It's going to be invalid, but they can accept the fixits. So something like
if (hasVarIntroducer || (!hasIntroducer && !hasInitializerModifier)) {and likewise for functions.
There was a problem hiding this comment.
👍 Makes sense!
And also for typealias. e.g. final typealias
|
Otherwise, LGTM! |
…ookup * If "required" or "convenience" is specified, emit only initializers * If "final" or "open" is specified, don't emit initializers or typealias * If "typealias" is specified, emit only associated type implementation * Emit "override" or "required" modifier for initializers * Emit access modifier for initializers * Emit designated initializers even if "override" is specified * Don't emit inheritance clause for associated type implentation
rintaro
force-pushed
the
cc-override-modifier
branch
from
d7d3a1e to
b827298
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test linux |
aaditya-chandrasekhar
pushed a commit
to val-verde/swift
that referenced
this pull request
Sep 30, 2022
…-05-06 Merge 5.7 2022-05-06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
requiredorconvenienceis specified, emit only initializersfinaloropenis specified, don't emit initializers or typealiastypealiasis specified, emit only associated type implementationoverrideorrequiredmodifier for initializersoverrideis specifiedBefore merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.