[Sema] [gardening] Refactor diagnoseMemoryLayoutMigration [NFC]

[xwu]

During implementation of SE-0136 in #4041 (restoring MemoryLayout.size(ofValue:) and related methods), a chunk of the diagnostics for MemoryLayout migration interfered with the restored methods and were therefore removed.

Although all functional changes were made in that PR, the diagnostics that remain could use some clean-up to remove unused plumbing. This PR provides that refactoring.

[slavapestov]

@swift-ci Please smoke test

[slavapestov]

Hi @xwu, sorry for losing track of this. Do you mind fixing the merge conflict and pushing a new version I can merge?

[xwu]

@slavapestov Done.

[slavapestov]

@swift-ci Please smoke test and merge

[slavapestov]

@xwu Thank you!

[xwu]

@slavapestov Seems Linux smoke test failed this time, but I can't see the details. One more try?

[slavapestov]

@swift-ci Please smoke test and merge

[slavapestov]

Looks like all builds are failing right now:

b/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_posix.cc.o: In function `__sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)':
/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:362: multiple definition of `__sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)'
lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_linux.cc.o:/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:1393: first defined here

@shahmishal Any ideas?

[slavapestov]

@swift-ci Please smoke test and merge

[shahmishal]

@slavapestov This was due to compiler-rt missing one fix, Anna already fixed it.

[erg]

This was due to a change that has been fixed.

On Oct 26, 2016, at 6:22 PM, Slava Pestov [email protected] wrote:

Looks like all builds are failing right now:

b/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_posix.cc.o: In function __sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)': /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_posix.cc:362: multiple definition of__sanitizer::FindAvailableMemoryRange(unsigned long, unsigned long, unsigned long)'
lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_linux.cc.o:/home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_linux.cc:1393: first defined here
@shahmishal https://github.com/shahmishal Any ideas?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub #4541 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AABrJt1qF3n_r8VW3FSTtIClO6A6hNVDks5q3_y5gaJpZM4JvHS3.